Upgrade to React 0.14 #1842
Draft
Upgrade to React 0.14 #1842
+335
−249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ysbaddaden
added
dependencies
ysbaddaden
force-pushed
the
tech-debt/upgrade-to-ruby-2.4
branch
from
4caa11a to
2accebc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick spike to upgrade from React 0.13 to React 0.14. I fixed a few deprecated features, and could upgrade the
react-selectdependency. Specs and features are all green (nice) and they don't print any deprecation warning in the JS console.I'm not sure feature specs are actually wide enough that they test all React components, so I'm still not very confident about this upgrade. There should be a thorough manual testing (with observation).
Bonus: it fixes Rails 5.0 deprecation warnings because we could update
react-rails(used to compile JSX). Maybe using Node & Webpack for building JavaScript instead of the Rails' assets pipeline would allow us to continue upgrading Rails, without having to upgrade React?Refs #1792